etcdserver: fill-in Auth API Header in apply layer #7753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyitsanthony
suggested changes
Apr 17, 2017
etcdserver/apply.go
Outdated
| @@ -815,3 +842,7 @@ func pruneKVs(rr *mvcc.RangeResult, isPrunable func(*mvccpb.KeyValue) bool) { | |||
| } | |||
| rr.KVs = rr.KVs[:j] | |||
| } | |||
|
|
|||
| func newHeader(s *EtcdServer) *pb.ResponseHeader { | |||
| return &pb.ResponseHeader{Revision: s.KV().Rev()} | |||
There was a problem hiding this comment.
shouldn't this fill out all the fields, though?
There was a problem hiding this comment.
Sure, let's fill them out as well.
heyitsanthony
approved these changes
Apr 17, 2017
gyuho
force-pushed
the
helper
branch
2 times, most recently
from
1c9b324 to
ce31f40
Compare
Replacing "etcdserver: fill a response header in auth RPCs" The revision should be set at the time of "apply", not in later RPC layer. Fix etcd-io#7691 Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
|
@gyuho thanks and sorry for my late work, yesterday I couldn't allocate a time for the previous versioin of PR... |
Codecov Report
@@ Coverage Diff @@
## master #7753 +/- ##
=========================================
Coverage ? 75.75%
=========================================
Files ? 331
Lines ? 26050
Branches ? 0
=========================================
Hits ? 19733
Misses ? 4893
Partials ? 1424
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #7716 (5e0f9eb).
Fix #7691.