-
Notifications
You must be signed in to change notification settings - Fork 741
Add option to force path style s3 uploads. #2036
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Because of the year change, the generated code verifier complained which prompted me to regenerate all the generated code. This makes the PR a bit more noisy than I'd like. If wanted, I can split up the PRs. |
@ainmosni yeah we don't need to update the year just go ahead and remove that and we can go from there. Thanks! |
84dce41
to
d5dd5c5
Compare
@hexfusion Done, cleaned out the generated code. |
@etcd-bot ok to test |
@ainmosni I am terribly sorry I skimmed through this quick and didn't realize these dates were machine generated output. So alas you will need to return these dates so that CI will pass. Again sorry about this, and thanks again for the PR and your time. |
@hexfusion No problem, I regenerated the code to have the local unit tests pass in the first place. 😁 I've readded them. |
This patch adds an option to force path style s3 uploads. This is useful when a third-party s3 endpoint doesn't support the subdomain style uploads that's default in s3.
1e90329
to
5255bd8
Compare
@hexfusion Done and done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ainmosni thank you! |
@hexfusion No, thank you, saves me from keeping a custom fork around to use our s3 setup. :) |
This patch adds an option to force path style s3 uploads. This is useful
when a third-party s3 endpoint doesn't support the subdomain style
uploads that's default in s3.
This is a fix for #2035.