pkg/*: Use endpoint status for probes

[avorima]

endpoint status doesn't require a username when authentication is enabled.

Fixes #1957

[etcd-bot]

Can one of the admins verify this patch?

[etcd-bot]

Can one of the admins verify this patch?

[etcd-bot]

Can one of the admins verify this patch?

[hexfusion]

@etcd-bot ok to test

[hexfusion]

@avorima I appreciate the PR this seems fine the result is the same and as you noted it allows auth. Can you please update the commit message to read pkg/*: Use endpoint status for probes also update CHANGELOG in a separate commit. Thanks!

[avorima]

@hexfusion Thanks for the quick response. Hope this is ok.

[hexfusion]

@avorima OK we are really close, but we need to get rid of the merge commit. And we would like all commit messages to be $package: $message

try

# remove merge commit
git reset --hard HEAD~1

# rename CHANGELOG commit
git commit --amend -m'CHANGELOG: updated to reflect probe fix'

# sanity check
git log

git push -f

Thanks!

[avorima]

@hexfusion What about the merge conflict?

[hexfusion]

@avorima I see you need to rebase against master.

[hexfusion]

lgtm, thanks @avorima!

[hexfusion]

@avorima I have run into an issue merging your commit because it has no email address.

please update with interactive rebase.

git rebase -i HEAD~2

you will see something like

pick 7c7141550 pkg/*: Use endpoint status for probes
pick a580ec454 CHANGELOG: updated to reflect probe fix

change pick to edit for both and save this will start the rebase.
for each

git commit --amend --author="Mario Valderrama <[email protected]>"
git rebase --continue

when done git push -f

Then please make sure to update your email address for future commits.
https://help.github.com/articles/setting-your-commit-email-address-in-git

Once this is done I can merge, thanks!

[avorima]

My bad, here you go.