pkg/*: Fix long cluster names causing pods to hang #2027
Conversation
alaypatel07
changed the title
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@alaypatel07 can you please rebase against master, thanks. |
alaypatel07
force-pushed
the
service-name
branch
from
a20836a to
a08ae87
Compare
|
@hexfusion sure, lemme know if I have to update the CHANGELOG too |
|
@etcd-bot ok to test |
|
@alaypatel07 yes, please add to CHANGELOG otherwise lgtm. |
|
Small nit on commit message, |
This patch restricts the name of the cluster to less than 52 characters. This simpler approach is preferred so it can be documented. Operator log displays appropriate error for users. Fixes coreos#1994
alaypatel07
force-pushed
the
service-name
branch
from
a08ae87 to
e1d3056
Compare
|
@alaypatel07 all we need is the CHANGELOG update and I can get this merged, thanks! |
|
Is this in any release already? We're continuously running into this issue. |
|
@christianhuening we are looking to cut a new release before the end of the month. |
|
@hexfusion alright thanks! |
|
Can someone take a look at #2043? I made sure my etcdcluster name was short, but I still have a problem with this stage. I'm working on an operator that uses this operator. |
|
@hexfusion Any updates on the release? We'd greatly appreciate it. Also because of #2026 . |
|
Updated on #2026 |
This patch restricts the name of the cluster to less than 52 characters. This simpler approach is preferred so it can be documented and explained to users easily. Operator log displays appropriate error for users.
Fixes #1994
Please read https://github.com/coreos/etcd-operator/blob/master/CONTRIBUTING.md#contribution-flow