This repository has been archived by the owner on May 14, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
I just discussed with @xiang90, and figured out v3 implementation of discovery service cannot happen anytime soon. Problem is that current etcd code base heavily relies on v2 API https://github.com/coreos/etcd/blob/master/discovery/discovery.go#L143. Minimum requirements to deprecate v2 API in public discovery service are:
Even if we implement them all, etcd old versions (v3.x<=) will still write v2 data to discovery service servers. So the true deprecation of v2 storage backend in discovery service can only happen after v2 deprecation in etcd side (planned for v4). I still want to merge this PR, for v3 API reference implementation and for v2 data purge scripts. After this PR, I will add some docs on purge operations. |
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
hexfusion
added a commit
that referenced
this pull request
Sep 9, 2018
This PR is an update to #53 bumping etcd to v3.3.9 and go 1.10.3. Although dep will be replaced with vgo in the future keeping the tooling in sync with etcd with make management easier.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary work towards #52.
Goal is having good test coverage on current code base, so that we can safely migrate to etcd v3. This does not change any client-facing interface (etcd v2). Highlighted changes are:
vendor
Dockerfile
pkg/lockstring
, instead have mutex inside shared states between handlersIn next PR, I will add v3 API option, with migration e2e tests.