cmd-kola: add support for kola-blacklist.yaml #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
approved these changes
Oct 22, 2019
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Oct 22, 2019
This will contain a documented list of tests known to fail right now. For details, see the corresponding cosa PR which learns how to read this, and the mantle RFE: coreos/coreos-assembler#866 https://github.com/coreos/mantle/issues/1103
Rather than encoding the blacklist in three different places (the fedora-coreos-config CI, the coreos-assembler CI, and the pipeline), let's just teach `cosa kola` to auto-detect a `kola-blacklist.yaml` from the src config and automatically blacklisting them when executing kola. I proposed making this baked in kola itself with slightly different semantics in: https://github.com/coreos/mantle/issues/1103 Though teaching this to cosa should still make things easier to maintain for now at least.
jlebon
force-pushed
the
pr/kola-blacklist
branch
from
2ed535a to
6467811
Compare
|
This and coreos/fedora-coreos-config#203 should unblock the pipeline. |
|
CI failure is from |
jlebon
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Oct 22, 2019
This will contain a documented list of tests known to fail right now. For details, see the corresponding cosa PR which learns how to read this, and the mantle RFE: coreos/coreos-assembler#866 https://github.com/coreos/mantle/issues/1103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than encoding the blacklist in three different places (the
fedora-coreos-config CI, the coreos-assembler CI, and the pipeline),
let's just teach
cosa kolato auto-detect akola-blacklist.yamlfromthe src config and automatically blacklisting them when executing kola.
I proposed making this baked in kola itself with slightly different
semantics in: https://github.com/coreos/mantle/issues/1103
Though teaching this to cosa should still make things easier to maintain
for now at least.