mantle/kola/tests: Use qemu platform only

[travier]

mantle/kola/tests: Replace 'qemu-unpriv' with 'qemu'

There is no longer a privileged 'qemu' platform and the 'qemu' and
'qemu-unpriv' platforms are the same.

Let's use qemu everywhere in order to be able to remove all
'qemu-unpriv' usage.

---

docs: Replace 'qemu-unpriv' with 'qemu'

There is no longer a privileged 'qemu' platform and the 'qemu' and
'qemu-unpriv' platforms are the same.

Let's use qemu everywhere in order to be able to remove all
'qemu-unpriv' usage.

---

kola: Remove 'qemu-unpriv' and make 'qemu' the default

There is no longer a privileged 'qemu' platform and the 'qemu' and
'qemu-unpriv' platforms are the same.

[travier]

Note: I have not tested that yet

[travier]

Maybe we should remove this entire file in favor of the doc in docs

[travier]

Cleanup for RHCOS in openshift/os#1142.

We could also consider dropping JSON support for kola tests configs as we no longer have that now.

[travier]

I am not certain about #3285 (comment) but apart from that this should be ready.

[dustymabe]

mostly LGTM a few comments

Extra Credit: The commit messages could use some context (i.e. there used to be qemu-unpriv and qemu but now there's only one, etc etc...).

[travier]

Will have to figure out the commits where those changes were previously made

[dustymabe]

LGTM

[travier]

I'm testing this change and the diff of the list of tests between COSA before and after this PR is not empty so I have to double check things. It adds things but it also removes some.

[dustymabe]

I'm testing this change and the diff of the list of tests between COSA before and after this PR is not empty so I have to double check things. It adds things but it also removes some.

Thank you for being thorough here!

[travier]

Updated diff:

--- main.list.sorted    2023-02-22 15:56:22.260544662 +0100
+++ new.list.sorted     2023-02-22 15:56:32.531605489 +0100
@@ -6,10 +6,11 @@
 coreos.ignition.groups
 coreos.ignition.instantiated.enable-unit[all]
 coreos.ignition.journald-log
+coreos.ignition.mount.disks
+coreos.ignition.mount.partitions
 coreos.ignition.once
-coreos.ignition.security.tls
 coreos.ignition.sethostname
-coreos.ignition.ssh.key
+coreos.ignition.symlink
 coreos.ignition.systemd.enable-service
 coreos.ignition.v2.users
 coreos.network.initramfs.second-boot
@@ -18,8 +19,6 @@
 coreos.tls.fetch-urls
 crio.base
 fcos.filesystem
-fcos.ignition.misc.empty
-fcos.ignition.v3.noop
 fcos.internet
 fcos.network.listeners
 fcos.users.shells
@@ -44,6 +43,8 @@
 rhcos.selinux.boolean.persist
 rhcos.selinux.manage
 rhcos.services-disabled
+rhcos.sssd
+rhcos.upgrade.from-ocp-rhcos
 rootfs.uuid
 rpmostree.install-uninstall
 rpmostree.status

[travier]

Summary of the change in tests -/+ here, based on my understanding of the tests, may be incomplete and will need review, based on kola list output:

Tests that will be skipped:

• coreos.ignition.security.tls: This requires two systems to test Ignition fetching over HTTPS with a custom CA and thus can not run on QEMU "unpriv" AFAIU
• coreos.ignition.ssh.key: This is redundant on QEMU has we always provision SSH keys via Ignition
• fcos.ignition.misc.empty: Requires the Ignition config to be fetched from cloud platform metadata
• fcos.ignition.v3.noop: Same as above

Additional tests that will be run:

• coreos.ignition.mount.disks
• coreos.ignition.mount.partitions
• coreos.ignition.symlink
• ext.config.ignition.delete-config
• ext.config.ignition.kargs
• ext.config.networking.bridge-static-via-kargs
• ext.config.networking.force-persist-ip
• ext.config.networking.ifname-karg.everyboot-systemd-link-file
• ext.config.networking.ifname-karg.udev-rule-firstboot-propagation
• ext.config.networking.kargs-rd-net
• ext.config.networking.mtu-on-bond-ignition
• ext.config.networking.mtu-on-bond-kargs
• ext.config.networking.nameserver
• ext.config.networking.no-default-initramfs-net-propagation.bootif
• ext.config.networking.no-persist-ip
• ext.config.networking.prefer-ignition-networking
• ext.config.networking.team-dhcp-via-ignition
• ext.config.ntp.chrony.coreos-platform-chrony-config
• ext.config.ntp.chrony.dhcp-propagation
• ext.config.ntp.timesyncd.dhcp-propagation
• ext.config.reboot
• ext.config.root-reprovision.linear
• ext.config.root-reprovision.raid1
• ext.config.root-reprovision.swap-before-root
• ext.config.secex.ensure
• ext.config.secex.reboot
• ext.config.var-mount.luks
• ext.config.var-mount.scsi-id
• ext.config.var-mount.simple
• rhcos.sssd
• rhcos.upgrade.from-ocp-rhcos

So overall this should now run more tests that before but a double check would be nice.

Summary of the steps taken to get this output:

cosa kola list > fcos.main.list
# build cosa from this branch
podman build -t localhost/coreos-assembler . --from quay.io/coreos-assembler/coreos-assembler:latest
export COREOS_ASSEMBLER_CONTAINER=localhost/coreos-assembler
cosa kola list > fcos.dev.list
sed -i "s/  \+/ /g" *.list
sed -i -e 's/\r*$/\r/' *.list
sort -o fcos.main.list fcos.main.list
sort -o fcos.dev.list fcos.dev.list
vimdiff fcos.main.list fcos.dev.list

[travier]

fcos.main.list.txt
fcos.dev.list.txt

[dustymabe]

maybe we should also mv mantle/platform/machine/unprivqemu mantle/platform/machine/qemu?

[dustymabe]

Summary of the change in tests -/+ here, based on my understanding of the tests, may be incomplete and will need review, based on kola list output:

Honestly I don't think there is any real change in behavior here. Yes, the kola list output is different but I think that is mostly because previously we mixed using qemu and qemu-unpriv in ExcludePlatforms or Platforms and I don't think kola list did enough evaluation to resolve that. If you actually run tests I think you'll notice that it behaves the same.

[dustymabe]

Thanks for working on this. A few comments..

[travier]

Thanks, updated.

[dustymabe]

LGTM

[cgwalters]

Just for reference this broke (one of) rpm-ostree's test suites, xref coreos/rpm-ostree#4477
Probably worth remembering to do a code search for removals in the future.

[travier]

Arg, thanks! Sorry for the trouble.