Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add bottlecap, an optional entry point #182

Merged
merged 1 commit into from
Nov 12, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
/target
**/*.rs.bk
src/__pycache__/*
.gocache
103 changes: 103 additions & 0 deletions bottlecap
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
#!/bin/sh

# bottlecap, 'cause it's kinda like cork... get it?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cork is nice since it's 4 letters :) - I like cass because it's also 4 letters, but I also like highlighting that this is the script vs an alias that someone has defined on the command line (since I like to define my alias as alias cass=. So cass.sh would be my suggestion here, but also takes us back to 7 characters so I'm a hypocrite :)

This was mostly just a thought excercise for me. We don't need to change anything unless you want to.


usage() {
echo "usage:"
echo "bottlecap [--dev] [--dry-run] [--runtime $runtime] [--build-dir $build_dir] [--container $container] assemblerargs..."
echo " --dev: rebuild and reinstall mantle, the build scripts, and the ostree-releng-scipts before running coreos-assembler"
echo " --dry-run: do not run CoreOS Assembler; print what commands would be executed instead"
echo " --runtime: (auto) specify whether to use podman or docker. Defaults to podman if it is in \$PATH"
dustymabe marked this conversation as resolved.
Show resolved Hide resolved
echo " --build-dir: Where to put build artifacts, defaults to the current directory"
echo " --container: which coreos-assembler container to use"
echo " --help: print this help message"
}

dev=0
dryrun=0
help=0
runtime="podman"
command -v podman > /dev/null || runtime="docker"
dustymabe marked this conversation as resolved.
Show resolved Hide resolved
build_dir="$(pwd)"
container="quay.io/cgwalters/coreos-assembler"

rc=0
TEMP=$(getopt -o 'dr:b:c:h' --long 'dev,dry-run,runtime:,build-dir:,container:,help' -- "$@") || rc=$?
if [ "$rc" -ne 0 ]; then
1>&2 echo "Bad arguments. getopt failed."
usage
exit 1
fi

eval set -- "$TEMP"

while :
dustymabe marked this conversation as resolved.
Show resolved Hide resolved
do
case "$1" in
"-d"|"--dev")
dev=1
shift
;;
"--dry-run")
dryrun=1
shift
;;
"-r"|"--runtime")
shift
runtime="$1"
shift
;;
"-b"|"--build-dir")
shift
build_dir=$(readlink -f "$1")
shift
;;
"-c"|"--container")
shift
container="$1"
shift
;;
"-h"|"--help")
help=1
shift
;;
--)
shift
break
;;
*)
1>&2 echo "Error parsing args"
exit 1
;;
esac
done

if [ "$help" = 1 ]; then
usage
dustymabe marked this conversation as resolved.
Show resolved Hide resolved
exit 0
fi

script_dir=$(dirname "$(readlink -f "$0")")

volumes="-v $build_dir:/srv "

entrypoint=""

if [ "$dev" = 1 ]; then
mkdir -p "$script_dir/.gocache"
volumes="$volumes -v $script_dir:/host/src "
volumes="$volumes -v $script_dir/.gocache:/root/.cache/go-build "
entrypoint="--entrypoint /host/src/bottlecap-shim"
fi

if [ "$dryrun" = 1 ]; then
# prefix $runtime with `echo` so the command is printed rather than executed
runtime="echo $runtime"
echo "Command to be executed:"
else
set -x
fi

# we actually want work splitting here since $volumes is multiple args
# shellcheck disable=SC2086
$runtime run --rm --net=host -ti --privileged --userns=host $volumes --workdir /srv $entrypoint "$container" "$@"
7 changes: 7 additions & 0 deletions bottlecap-shim
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/bin/bash

pushd /host/src/ || exit 1
sudo ./build.sh make_and_makeinstall
popd || exit 1

exec /usr/bin/coreos-assembler "$@"