Add RUNVM_NONET which skips dhclient in helper VM #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of speeding up `cosa build-fast`; here the `dhclient` run takes about a second out of 11 (after other speedups) so that's a 9% win. After rebasing on coreos#1289 I'll also drop out the virtio-net NIC entirely which will help us ensure tasks that shouldn't pull external content don't.
|
Neat! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This has notably caused any doesn't run a |
|
Ahh, right. Urgh, will look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of speeding up
cosa build-fast; here thedhclientrun takes about a second out of 11 (after other speedups) so
that's a 9% win. After rebasing on
#1289
I'll also drop out the virtio-net NIC entirely which will help
us ensure tasks that shouldn't pull external content don't.