devshell: Print status as we're booting #1369
Conversation
It's better than seconds of silence, and if e.g. we get stuck in the initramfs then it's more obvious. Closes: coreos#1367
| case err := <-errchan: | ||
| if err == platform.ErrInitramfsEmergency { | ||
| return fmt.Errorf("instance failed in initramfs; try rerunning with --devshell-console") | ||
| loop: |
There was a problem hiding this comment.
not a fan of labels, but meh
|
WDYT about the suggestion in #1367 (comment)? |
|
Let's at least land this since I hope everyone agrees it's an improvement, and if anyone wants something else, we can iterate from there? |
Absolutely..it's scary to just see nothing on the screen and wait suspense-fully to see whether it succeeds or not ;) That being said do we write the console output somewhere if it errors out (or otherwise) ? |
Infra flake |
|
/lgtm |
|
On Tue, Apr 21, 2020, at 11:11 AM, Stephen Milner wrote:
`[Could not resolve host: kojipkgs.fedoraproject.org]
`
Infra flake
It's #1379
|
|
I think CI needed #1378, where we added |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, darkmuggle, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's better than seconds of silence, and if e.g. we get stuck
in the initramfs then it's more obvious.
Closes: #1367