Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koji-upload: Replace - with . in versions #1053

Closed
wants to merge 1 commit into from
Closed

koji-upload: Replace - with . in versions #1053

wants to merge 1 commit into from

Conversation

darkmuggle
Copy link
Contributor

Enforce NVR rules for Koji

@cgwalters
Copy link
Member

cgwalters commented Jan 15, 2020

Seems reasonable but, let's add the rationale here to both the commit message and a comment in the source file. Something like:

koji-upload: Replace `-` with `.` in versions

For RHCOS we are trying to make use of `-` as a version character in order to be semver-compatible.
See https://github.com/openshift/oc/pull/209#issuecomment-564876535

However, Koji rejects this, so we'll just convert it for now, accepting the divergence in version numbers.

And in the code:

# RHCOS wants to be semver-compatible, but Koji doesn't accept `-`.  See
# https://github.com/openshift/oc/pull/209#issuecomment-564876535

?

@darkmuggle
Copy link
Contributor Author

Updated the commit message. Running this through the pipeline.

For RHCOS we are trying to make use of `-` as a version character in order to be semver-compatible.
See openshift/oc#209 (comment)
@darkmuggle darkmuggle marked this pull request as ready for review January 15, 2020 19:15
@darkmuggle
Copy link
Contributor Author

Waiting for end-to-end testing.

@cgwalters cgwalters changed the title cmd-kojiupload: use dot in NVR cmd-kojiupload: Convert - to . in versions Jan 15, 2020
@cgwalters cgwalters changed the title cmd-kojiupload: Convert - to . in versions koji-upload: Replace - with . in versions Jan 15, 2020
@cgwalters
Copy link
Member

This this one get tested? Seems safe enough to merge.

@jlebon
Copy link
Member

jlebon commented Jan 17, 2020

Looks like this was merged as part of #1060.

@jlebon jlebon closed this Jan 17, 2020
@darkmuggle darkmuggle deleted the pr/koji-blows branch February 18, 2020 21:48
jcajka pushed a commit to jcajka/coreos-assembler that referenced this pull request Mar 24, 2020
test: add mod=vendor to everything in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants