Add cmd-test-coreos-installer #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
commented
Jan 8, 2020
cgwalters
commented
Jan 8, 2020
darkmuggle
approved these changes
Jan 8, 2020
cgwalters
force-pushed
the
test-e2e-installer
branch
2 times, most recently
from
9bdad93 to
0182f8c
Compare
|
Updated 🆕
(I do want to rewrite this in Go in kola sometime soon but I don't think it's worth waiting for that) |
jlebon
reviewed
Jan 9, 2020
| buildid=$(jq -er .buildid < ${buildmeta}) | ||
| metalimg=$(jq -er .images.metal.path < ${buildmeta}) | ||
| instkernel=$(jq -er .images.kernel.path < ${buildmeta}) | ||
| instinitramfs=$(jq -er .images.initramfs.path < ${buildmeta}) |
There was a problem hiding this comment.
In light of coreos/fedora-coreos-tracker#203, we'll want to at least for now make this configurable to use the live versions if possible. The kargs interface should be the same otherwise so we shouldn't have to change anything else.
We can do this in a follow-up though if you prefer!
There was a problem hiding this comment.
Yeah I just want to get any coverage of the installer path for RHCOS right now.
We have no coverage of coreos-installer today. This was a quick hacky shell script I wrote a few months ago and posted as a gist: https://gist.github.com/cgwalters/bf6f5b6f788d01211dbe6cd362309a0d This could obviously be cleaned up and de-duped with kola and other cosa bits, but for now, let's just get some coverage. Specifically e.g. one thing I want to do is support running a specific kola suite (maybe just `basic`) against the newly installed image.
cgwalters
force-pushed
the
test-e2e-installer
branch
from
0182f8c to
72a1d4f
Compare
jlebon
approved these changes
Jan 9, 2020
jcajka
pushed a commit
to jcajka/coreos-assembler
that referenced
this pull request
Mar 24, 2020
The `createImage` call currently can fail when attempting to tag the AMI Name due to eventual consistency issues. Add a `RetryConditional` to retry up to 6 times when `InvalidAMIID.NotFound` is returned by the SDK. Closes coreos#1030 Closes coreos#1091
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have no coverage of coreos-installer today. This was a quick
hacky shell script I wrote a few months ago and posted as a gist:
https://gist.github.com/cgwalters/bf6f5b6f788d01211dbe6cd362309a0d
This could obviously be cleaned up and de-duped with kola and
other cosa bits, but for now, let's just get some coverage.
Specifically e.g. one thing I want to do is support running
a specific kola suite (maybe just
basic) against the newly installed image.