Skip to content

Commit

Permalink
kola/testiso: test that default path is fully offline
Browse files Browse the repository at this point in the history
I'd like to get coverage for
coreos/coreos-installer#197 before it merges and
we do a release with it.

To do that, I want to test that the default installation path no longer
requires Internet access. Here, "default" means we pass neither
`--offline` nor `--stream` nor `--image-url` to
`coreos-installer install`.

Change the new `iso-offline-install` scenario to cover this; all we need
to do is remove the explicit `--offline`.

This scenario will only pass for now if the build under test has that PR
and the live ISO has the osmet files (which right now is gated behind
`--osmet`).

Once that PR is in FCOS proper, we can make `--osmet` the default and
this test will then always pass.
  • Loading branch information
jlebon authored and openshift-merge-robot committed Apr 30, 2020
1 parent 5a3a464 commit 246862c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion mantle/platform/metal.go
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,9 @@ func (inst *Install) InstallViaISOEmbed(kargs []string, liveIgnition, targetIgni
var srcOpt string
var serializedTargetConfig string
if offline {
srcOpt = "--offline"
// note we leave srcOpt as "" here; offline installs should now be the
// default!

// we want to test that a full offline install works; that includes the
// final installed host booting offline
serializedTargetConfig = dataurl.EncodeBytes([]byte(renderedTarget))
Expand Down

0 comments on commit 246862c

Please sign in to comment.