Dont depend on systemd on all non-windows targets #4
Conversation
metux
force-pushed
the
submit/dont-depend-on-systemd
branch
from
65498cd to
5143c80
Compare
| @@ -12,14 +12,12 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
| // | |||
| // +build !windows | |||
| // +build !windows,!journald | |||
There was a problem hiding this comment.
The default behavior on Linux should not change and should not require a new build tag
There was a problem hiding this comment.
The default behavior on Linux should not change and should not require a new build tag
Do you have any better idea for getting rid this useless code ?
On LINUX this code does pretty much NOTHING (throwing errors) when running as direct child of init
(that alone is just a ridiculously unreliable way to check for being a daemon) - that only works on Poetterix.
There was a problem hiding this comment.
Adding no_journald tag might be fine (if it has significant benefit on footprint)
Systemd is purely Linux specific, even there and only running on some distros, thus making the switch on whether we're not on Windows is just wrong. Instead it should only be enabled when we're really building for some systemd/journald based platform. Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
metux
force-pushed
the
submit/dont-depend-on-systemd
branch
from
5143c80 to
503bd65
Compare
|
This repo was an attempt to split |
Systemd is purely Linux specific, even there and only running on some
distros, thus making the switch on whether we're not on Windows is
just wrong.
Instead it should only be enabled when we're really building for some
systemd/journald based platform.
Signed-off-by: Enrico Weigelt, metux IT consult [email protected]