db.go: clean up file descriptor on init/read failures #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where failing to open a non-existent database in ReadOnly mode would make you unable to properly initialize it in ReadWrite mode afterwards due to a hanging lock.
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
=========================================
Coverage ? 85.47%
=========================================
Files ? 9
Lines ? 1859
Branches ? 0
=========================================
Hits ? 1589
Misses ? 160
Partials ? 110
Continue to review full report at Codecov.
|
heyitsanthony
approved these changes
Mar 17, 2018
Signed-off-by: Gyuho Lee <[email protected]>
gyuho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where failing to open a non-existent database in ReadOnly
mode would make you unable to properly initialize it in ReadWrite mode
afterwards due to a hanging lock.
boltdb/bolt#725
/cc @xiang90 @heyitsanthony