This repository has been archived by the owner on Mar 9, 2019. It is now read-only.
Cleanup file descriptors on failed database initialization #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where failing to open a non-existent database in ReadOnly mode would make you unable to properly initialize it in ReadWrite mode afterwards due to a hanging lock.
| @@ -193,10 +193,12 @@ func Open(path string, mode os.FileMode, options *Options) (*DB, error) { | |||
|
|
|||
| // Initialize the database if it doesn't exist. | |||
| if info, err := db.file.Stat(); err != nil { | |||
| db.close() | |||
| return nil, err | ||
| } else if info.Size() == 0 { | ||
| // Initialize new files with meta pages. | ||
| if err := db.init(); err != nil { | ||
| db.close() |
|
@Ssawa this patch probably won't get merged here, but I'll be happy to add it to http://github.com/coreos/bbolt |
|
Agressive ad.
…On jeu. 31 août 2017 00:48 Anthony Romano ***@***.***> wrote:
@Ssawa <https://github.com/ssawa> this patch probably won't get merged
here, but I'll be happy to add it to http://github.com/coreos/bbolt
<https://github.com/coreos/bbolt>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#725 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAGwMHmfiEWVtY1FvZPyuI2hOzSNPWQSks5sdebTgaJpZM4PGsAP>
.
|
|
@vincent-petithory my apologies for trying to maintain this software |
This was referenced Mar 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this one today on a Unix system...
So when you try to open up a Bolt db that doesn't exist already exist in ReadOnly mode you get an
os.PathErrorwhen initializing your meta pages and Bolt returnsniland the error. Which makes sense; you've opened (and created) the file with theO_RDONLYflag and are now trying to write to it. I don't, personally, think that in ReadOnly mode you should initialize the database.However the issue is that this happens after you've acquired your shared lock on the FD and you now have no (direct) means of releasing it (because you've been passed back only
nil). So if in my program I want to handle this error by creating and initializing a new database in ReadWrite mode I can't because I hang indefinitely waiting for my exclusive lock.All that this change does is make sure we call close on our partially created database before returning, closing our file so that a subsequent call to Open has a chance of acquiring an exclusive lock on the file.