Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): add restriction to prom metrics #78

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

charltonaustin
Copy link
Contributor

this removes the cluster level configuration

Issue: https://coreosdev.atlassian.net/browse/QUAY-598

  • It works!
  • Comments provide sufficient explanations for the next contributor
  • Tests cover changes and corner cases
  • Follows Quay syntax patterns and format

@charltonaustin charltonaustin requested a review from ecordell June 13, 2017 15:13
@charltonaustin charltonaustin force-pushed the remove_non_apostille_helm_stuff branch from 6df2a70 to d42cb94 Compare June 13, 2017 15:16
@charltonaustin charltonaustin changed the title fix(helm): remove cluster level stuff fix(helm): add restriction to prom metrics Jun 13, 2017
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you move the extra files to quay-policies?

Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

this removes the cluster level configuration
it also adds in restrictions to prom metrics

Issue: https://coreosdev.atlassian.net/browse/QUAY-598

- [ ] It works!
- [ ] Comments provide sufficient explanations for the next contributor
- [ ] Tests cover changes and corner cases
- [ ] Follows Quay syntax patterns and format
@charltonaustin charltonaustin force-pushed the remove_non_apostille_helm_stuff branch from d42cb94 to dfbcdaa Compare June 14, 2017 20:47
@charltonaustin charltonaustin merged commit e6cb30a into master Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants