remove ignored options from kubernetes plugin #3737
Conversation
zouyee
requested review from
bradbeam,
chrisohaver,
johnbelamaric,
miekg,
rajansandeep and
yongtang
as code owners
|
yes, we've never done this because it's backwards incompatible and forces folks to update config for no real good reason (i.e. -5 lines). This needs to happen at some point, but there is no rush IMO |
|
we might as well dump this in 1.7.0? |
yes, i'll reopen the issue. |
Signed-off-by: zounengren <[email protected]>
|
/assign @chrisohaver |
Codecov Report
@@ Coverage Diff @@
## master #3737 +/- ##
==========================================
+ Coverage 56.72% 56.74% +0.02%
==========================================
Files 222 222
Lines 11296 11292 -4
==========================================
Hits 6408 6408
+ Misses 4395 4391 -4
Partials 493 493
Continue to review full report at Codecov.
|
|
@miekg PTAL |
|
[ Quoting <[email protected]> in "Re: [coredns/coredns] remove ignore..." ]
/retest
this would be a nice command to implement in your bot, don't know how though as github
doesn't expose it; you need to talk directly to travis and circle-ci as far as I know.
|
got it, thanks! |
|
@chrisohaver PTAL |
Signed-off-by: zounengren <[email protected]>
coredns/coredns#3737 removed the unused `upstream` kubernetes plugin option from the CoreDNS corefile parser. Starting in CoreDNS v1.7, corefiles that have the `upstream` option will throw an error. This change should not affect functionality since the `upstream` option has been ignored since CoreDNS v1.5. The aforementioned upstream CoreDNS PR merely requires that the `upstream` option be removed for the kubernetes plugin section of a corefile.
* Uplift the CoreDNS image to 1.7.0 (aligning to k8s v1.20) [0] * Update the Corefile based on corefile-tool migration [1] Note that the previously-deprecated "upstream" option is removed in 1.7.0 [2], and if not removed from the Corefile, will cause the pods to crashloop. 0: https://github.com/coredns/deployment/blob/master/kubernetes/CoreDNS-k8s_version.md 1: https://github.com/coredns/corefile-migration/tree/master/corefile-tool 2: coredns/coredns#3737 Change-Id: I03882240e8335f09956e412345e783e9a897ed9a
Signed-off-by: zouyee [email protected]
1. Why is this pull request needed and what does it do?
code pruning which remove ignored options from kubernetes plugin.
2. Which issues (if any) are related?
#3731
3. Which documentation changes (if any) need to be made?
none
4. Does this introduce a backward incompatible change or deprecation?
Yes. will cause CoreDNS to exit if
resyncperiodofupstreamoptions are present