Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/etcd: upgrade to go.etcd.io/etc import path #3087

Closed
miekg opened this issue Aug 2, 2019 · 2 comments · Fixed by #3214
Closed

plugin/etcd: upgrade to go.etcd.io/etc import path #3087

miekg opened this issue Aug 2, 2019 · 2 comments · Fixed by #3214

Comments

@miekg
Copy link
Member

miekg commented Aug 2, 2019

etcd moved their import paths to go.etcd.io/etc. But if I try to use the new ones I get the following error:

plugin/etcd/etcd.go:80:22: cannot use r.Kvs (type []*"github.com/coreos/etcd/mvcc/mvccpb".KeyValue) as type []*"go.etcd.io/etcd/mvcc/mvccpb".KeyValue in argument to e.loopNodes

Some indirect dependencies is pulling down etcd from the older location and somehow this gets used when compiling this.

I tried playing around with replace and exclude in go.mod but no avail.
I also don't know how to track down which indirect dep is pulling it on the older name

@chrisohaver
Copy link
Member

There is go mod why ... e.g. go mod why -m github.com/coreos/etcd which helps a little.
That says ...

# github.com/coreos/etcd
github.com/coredns/coredns/plugin/etcd
go.etcd.io/etcd/clientv3
github.com/coreos/etcd/auth/authpb

Digging into it, it looks that 3.3.13 still references the old path in some files in go.etcd.io/etcd/clientv3. It appears to be fixed in master.

@miekg
Copy link
Member Author

miekg commented Aug 7, 2019

etcd-io/etcd#10943 They aim for a release on August 30

miekg added a commit that referenced this issue Aug 27, 2019
This moves the entire etcd to go.etcd.io, so that it compiles cleanly
when using bazel.

Fixes: #3087

Signed-off-by: Miek Gieben <[email protected]>
yongtang pushed a commit that referenced this issue Aug 27, 2019
This moves the entire etcd to go.etcd.io, so that it compiles cleanly
when using bazel.

Fixes: #3087

Signed-off-by: Miek Gieben <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants