fix: avoid modifying commissions beyond the limited range

coredao-org · Jun 2, 2023 · b7f5427 · b7f5427
1 parent d247dc9
commit b7f5427
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/contracts/CandidateHub.sol b/contracts/CandidateHub.sol
@@ -307,7 +307,7 @@ contract CandidateHub is ICandidateHub, System, IParamSubscriber {
     );
     if (roundTag != c.commissionLastChangeRound) {
       c.commissionLastChangeRound = roundTag;
-      c.commissionLastRoundValue = commissionThousandths;
+      c.commissionLastRoundValue = c.commissionThousandths;
     }
     if (c.consensusAddr != consensusAddr) {
       require(consensusMap[consensusAddr] == 0, "the consensus already exists");

diff --git a/contracts/CandidateHub.template b/contracts/CandidateHub.template
@@ -319,7 +319,7 @@ contract CandidateHub is ICandidateHub, System, IParamSubscriber {
     );
     if (roundTag != c.commissionLastChangeRound) {
       c.commissionLastChangeRound = roundTag;
-      c.commissionLastRoundValue = commissionThousandths;
+      c.commissionLastRoundValue = c.commissionThousandths;
     }
     if (c.consensusAddr != consensusAddr) {
       require(consensusMap[consensusAddr] == 0, "the consensus already exists");