Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missed dependencies + types package #1431

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

missed dependencies + types package #1431

wants to merge 9 commits into from

Conversation

hextion
Copy link
Collaborator

@hextion hextion commented Oct 29, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 174db10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 98 packages
Name Type
@alfalab/core-components-accordion Patch
@alfalab/core-components-action-button Patch
@alfalab/core-components-attach Patch
@alfalab/core-components-backdrop Patch
@alfalab/core-components-badge Patch
@alfalab/core-components-bank-card Patch
@alfalab/core-components-base-modal Patch
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components-calendar Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-chart Patch
@alfalab/core-components-checkbox Patch
@alfalab/core-components-collapse Patch
@alfalab/core-components-confirmation-v1 Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-dropzone Patch
@alfalab/core-components-file-upload-item Patch
@alfalab/core-components-file-upload-item-v1 Patch
@alfalab/core-components-filter-tag Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-indicator Patch
@alfalab/core-components-input Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-mq Patch
@alfalab/core-components-navigation-bar Patch
@alfalab/core-components-navigation-bar-private Patch
@alfalab/core-components-notification Patch
@alfalab/core-components-number-input Patch
@alfalab/core-components-pagination Patch
@alfalab/core-components-pass-code Patch
@alfalab/core-components-pass-code-v1 Patch
@alfalab/core-components-password-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-plate Patch
@alfalab/core-components-popover Patch
@alfalab/core-components-popup-sheet Patch
@alfalab/core-components-product-cover Patch
@alfalab/core-components-pure-cell Patch
@alfalab/core-components-scrollbar Patch
@alfalab/core-components-select Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-shared Patch
@alfalab/core-components-sortable-list Patch
@alfalab/core-components-stack Patch
@alfalab/core-components-status-badge Patch
@alfalab/core-components-steps Patch
@alfalab/core-components-system-message Patch
@alfalab/core-components-tabs Patch
@alfalab/core-components-text Patch
@alfalab/core-components-toast-plate Patch
@alfalab/core-components-types Patch
@alfalab/core-components-underlay Patch
@alfalab/core-components-universal-date-input Patch
@alfalab/core-components-drawer Patch
@alfalab/core-components-modal Patch
@alfalab/core-components-side-panel Patch
@alfalab/core-components-tooltip Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-tab-bar Patch
@alfalab/core-components-amount-input Patch
@alfalab/core-components-date-input Patch
@alfalab/core-components-masked-input Patch
@alfalab/core-components-slider-input Patch
@alfalab/core-components-time-input Patch
@alfalab/core-components-with-suffix Patch
@alfalab/core-components-button Patch
@alfalab/core-components-checkbox-group Patch
@alfalab/core-components-code-input Patch
@alfalab/core-components-confirmation Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-form-control Patch
@alfalab/core-components-markdown Patch
@alfalab/core-components-pattern-lock-v1 Patch
@alfalab/core-components-pattern-lock Patch
@alfalab/core-components-radio-group Patch
@alfalab/core-components-tag Patch
@alfalab/core-components-textarea Patch
@alfalab/core-components-toast Patch
@alfalab/core-components-typography Patch
@alfalab/core-components-notification-manager Patch
@alfalab/core-components-table Patch
@alfalab/core-components-alert Patch
@alfalab/core-components-portal Patch
@alfalab/core-components-radio Patch
@alfalab/core-components-spinner Patch
@alfalab/core-components-switch Patch
@alfalab/core-components-phone-input Patch
@alfalab/core-components-custom-button Patch
@alfalab/core-components-icon-button Patch
@alfalab/core-components-circular-progress-bar Patch
@alfalab/core-components-comment Patch
@alfalab/core-components-list-header Patch
@alfalab/core-components-list Patch
@alfalab/core-components-stepped-progress-bar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Oct 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11970041235

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 82.398%
Totals Coverage Status
Change from base Build 11959593160: -0.005%
Covered Lines: 10616
Relevant Lines: 11762
💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

reme3d2y
reme3d2y reviewed Oct 30, 2024
View reviewed changes
packages/chart/src/hoc/Customized.tsx Outdated
/* eslint-disable @typescript-eslint/no-explicit-any */
import React from 'react';

export const CustomizedHOC = (Component: any, options: any) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А это что?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это было на javascript написано, перевел на ts

core-components/packages/chart/src/hoc/Customized.jsx

Line 1 in 7c8606e

import React from 'react';

@hextion hextion force-pushed the rollup-build-ts branch 4 times, most recently from fb92549 to 2dda056 Compare October 30, 2024 21:54
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@hextion hextion changed the title Rollup build ts missed dependencies + types package Nov 1, 2024
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Bundle size report

Entry point Size (minified)
select-with-tags/index.js 312 (-2.20 KB)
select-with-tags/mobile.js 285.8 (-2.20 KB)
picker-button/index.js 317.6 (-2.10 KB)

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulcanellee fulcanellee fulcanellee approved these changes

@reme3d2y reme3d2y reme3d2y approved these changes

@SiebenSieben SiebenSieben Awaiting requested review from SiebenSieben SiebenSieben is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hextion @coveralls @core-ds-bot @reme3d2y @fulcanellee