Skip to content
This repository has been archived by the owner on Mar 18, 2019. It is now read-only.

Prevent path/param drop when both fields have the same name. #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent path/param drop when both fields have the same name. #138

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 7, 2017

Attempt to fix #137. While this might not be the best way, it demonstrates extracting path parameters first.

@thinkwelltwd
Copy link

thinkwelltwd commented Jun 7, 2017

@hurturk, that's working for me!

@tomchristie, would there be some way to specify a path param separately from the field params, so that the lookup_field value could be updated just as an HTML form?

@ghost
Copy link
Author

ghost commented Jun 8, 2017

Doc generated cli command already show two consequent parameters with same name fyi. Alternative solution would be to take first one as a path and the later as data.

Or if lookup_field can be used in a way just like the example in the coreapi-cli readme:

coreapi show notes 0 description

Here, instead of 0, I think lookup_field could be used? I can certainly make another PR for that when decided.

@ghost ghost changed the title Prevent path/param drop when both fields has the same name. Prevent path/param drop when both fields have the same name. Jun 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL not constructed in PUT/PATCH methods
2 participants