This repository has been archived by the owner on Mar 18, 2019. It is now read-only.
debug_request: do not mess with HTTP_HOST header #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `coreapi get http://127.0.0.1:8000/api/schema/ --debug` would set the "host" header to only the hostname ("127.0.0.1"), while it is supposed to also include the port. Since it is only meant for display/debug here, also use a copy of `request.headers` when changing them.
|
Brill thanks! Alternative fix at #26. Really appreciate your time! 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
coreapi get http://127.0.0.1:8000/api/schema/ --debugwouldset the "host" header to only the hostname ("127.0.0.1"), while it is
supposed to also include the port.
Since it is only meant for display/debug here, also use a copy
of
request.headerswhen changing them.