Support for WKWebView

[ramezrafla]

The next generation of IOS browser is out:
https://developer.apple.com/library/ios/documentation/WebKit/Reference/WKWebView_Ref/

Does this plugin support this type of webview (instead of UIView)? Or can we at least coexist (i.e. if we run cordova within wkwebview instead of UIView?)

Thanks

[saghul]

You'll need to wait for the Cordova iOS platform 4.0, which allows to choose the type of webview required. The plugin will need to be updated, but changes are minimal, I made them here: https://github.com/saghul/cordova-plugin-iosrtc/tree/ios-platform-4

[yocontra]

You can also use this for the interim: https://github.com/Telerik-Verified-Plugins/WKWebView

[ibc]

Would be something like this enough to achieve the goal of this issue?

alongubkin/phonertc@e94c680

[saghul]

See my patch. That does it, but 4.0.0 is not out yet.
On Nov 26, 2015 21:36, "Iñaki Baz Castillo" [email protected]
wrote:

Would be something like this enough to achieve the goal of this issue?

alongubkin/phonertc@e94c680
alongubkin/phonertc@e94c680

—
Reply to this email directly or view it on GitHub
#90 (comment)
.

[ibc]

Nide, so let's wait for 4.0.0 before you send such a PR :)

[ballenjr]

Looks like 4.0.x is out. https://github.com/apache/cordova-ios/releases/tag/4.0.1

[yocontra]

@saghul Got time to send a PR for this now that 4.0 is out? 🍾

[saghul]

Oh, looks like it was released 8 december, indeed: https://cordova.apache.org/announcements/2015/12/08/cordova-ios-4.0.0.html

I'll make a PR soon.

[saghul]

I updated my branch (https://github.com/saghul/cordova-plugin-iosrtc/tree/ios-platform-4) so it compiles now, but my app is behaving weirdly, so I haven't been able to test this properly yet.

[saghul]

This is completely bizarre, none of my plugins load and the debugger gets disconnected automagically after updating to iOS platform 4.0.1. Sigh.

[saghul]

Ok, managed to launch the app with a WKWebView and the plugin, but now it crashes when trying to make a call, somewhere inside the iosrtc plugin. Fun times ahead, I guess.

[ibc]

Does such a crash just happen with your "WKWebView" based fork?

[saghul]

Yep.

[ibc]

happy christmas anyway!

[saghul]

Good / bad news: the crash also happens when NOT using a WKWebView, so it seems related to the iOS platform upgrade to 4.0.0.

[ibc]

Are you 100% sure it is not a fucking "memory warning" upgraded to "iOS killed me due to memory usage"? I've seen TONS of them, and usually they are not related to the iosrtc plugin, but to the usage of some cool CSS transition effect or too much loaded images.

[saghul]

Yeah, pretty sure. I get some EXC_BAD_ACCESS when doing a getUserMedia, on the first line in saveMediaStream.

[ibc]

You are not calling that within a WebSocket event, right?

[saghul]

No, though I do for incoming calls. I do have the hack applied though. It works right now, so I'm trying to figure out what the problem could be...

[telemakhos]

Just FYI: this is also being re-worked and close to completion here. Both UIWebView and WKWebView seem to be working, including fixes for the HTML/transparency trick...

[mark-veenstra]

@ibc @saghul is there still work going on to get WKWebView working?

[ibc]

@telemakhos thanks for that useful link. It seems that some work must be done in order to use Cordova iOS 4.0.0.

@mark-veenstra I cannot spend time on this. @saghul already did some work. The remaining work seems doable by following same steps as those done here. Pull requests are welcome in the meanwhile.

[saghul]

@mark-veenstra if you look at the PR I sent, the changes required to make it build are very small. Unfortunately I have no clue why it randomly crashed. But it looked similar to #144. Feel free to apply saghul@90a7c35 on top of master and try to debug it...

[mark-veenstra]

I have applied the patch from @saghul to the current master (which includes the fix). But I still encounter a EXC_BREAKPOINT on this line.

I have read the steps from here, but I don't see where it is used in iosrtc. Any ideas?

EDIT:
Seems like you still need to install cordova-plugin-wkwebview-engine seperately, but I still encounter the file:// issues with WKWebView.

[ibc]

The plugin has been updated to Cordova iOS 4, so let's this game continue.

[saghul]

@ibc I believe you can close this one.

[ibc]

OK, so this will be available in 3.0.0.