Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extras: Add Pydantic type for Rut #696

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jtrobles-cdd
Copy link
Member

  • Add Pydantic type cl_sii.extras.pydantic_types.Rut that can be used in place of cl_sii.rut.Rut in Pydantic models and Pydantic data classes.
  • Add extra pydantic to Python package.

Ref: https://app.shortcut.com/cordada/story/9729 [sc-9729]

@jtrobles-cdd jtrobles-cdd added the enhancement New feature or request label Sep 24, 2024
@jtrobles-cdd jtrobles-cdd self-assigned this Sep 24, 2024
@jtrobles-cdd jtrobles-cdd requested a review from a team as a code owner September 24, 2024 16:13
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.45%. Comparing base (d3c0fd1) to head (945ee65).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #696      +/-   ##
===========================================
+ Coverage    87.36%   87.45%   +0.08%     
===========================================
  Files           37       38       +1     
  Lines         3070     3092      +22     
  Branches       379      381       +2     
===========================================
+ Hits          2682     2704      +22     
  Misses         246      246              
  Partials       142      142              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtrobles-cdd jtrobles-cdd force-pushed the feature/add-pydantic-rut-field branch 2 times, most recently from eee0e2b to ba69175 Compare September 24, 2024 16:40
- Add Pydantic type `cl_sii.extras.pydantic_types.Rut` that can be used
  in place of `cl_sii.rut.Rut` in Pydantic models and Pydantic data classes.
- Add extra `pydantic` to Python package.

Ref: https://app.shortcut.com/cordada/story/9729 [sc-9729]
Copy link

sonarcloud bot commented Sep 24, 2024

@jtrobles-cdd jtrobles-cdd merged commit d78423d into develop Sep 24, 2024
18 checks passed
@jtrobles-cdd jtrobles-cdd deleted the feature/add-pydantic-rut-field branch September 24, 2024 19:13
@svillegas-cdd svillegas-cdd mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants