Make AccountInfo.identifier.externalId more usable #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to add/link more data with a Corda Account. After looking at issues, i found #77 where @roger3cev naturally makes the reasonable proposal of using the
linearId
'sexternalId
to map with client application concerns.However, an
AccountInfo
'sexternalId
is impossible to use with the current version of master, mainly because:CreateAccount
flow doesn't allow setting an (optional) externalId.PersistentAccountInfo
.This PR tries to accommodate users that need to utilise
externalId
accordingly with the following minimal changes:PersistentAccountInfo.externalId
to allow creatingVaultCustomQueryCriteria
with it .AccountInfoByExternalId
flow on par withAccountInfoByXX
flows that already exist.CreateAccount
flow to setlinearId.externalId
when creating accounts.AccountService.accountInfoByExternalId
method, had to break the convention and add a suffix as theaccountInfo(String)
signature is already used for querying by name.accountExternalIdCriteria
utility method per what seems as a convention within the workflows module.Create and query accounts by externalId
inAccountInfoTests
, to ensure users can query byexternalId
after creating, receiving or requesting accounts.RequestHostedAccountInfoByExternalId...
flow variants.I state that this PR is in accordance with the Developer's Certificate of Origin.