has length panicked with nil actual

corbym · Jan 21, 2018 · 190aad5 · 190aad5
1 parent 73c35b3
commit 190aad5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/has/haslength.go b/has/haslength.go
@@ -14,6 +14,9 @@ func Length(expected interface{}) *gocrest.Matcher {
 	matcher := new(gocrest.Matcher)
 	matcher.Describe = fmt.Sprintf(description, expected)
 	matcher.Matches = func(actual interface{}) bool {
+		if actual == nil {
+			return false
+		}
 		lenOfActual := reflect.ValueOf(actual).Len()
 		matcher.Actual = fmt.Sprintf("length was %d", lenOfActual)
 		typeMatcher, ok := expected.(*gocrest.Matcher)

diff --git a/matcher_test.go b/matcher_test.go
@@ -21,6 +21,7 @@ func TestHasLengthMatchesOrNot(testing *testing.T) {
 		expected   interface{}
 		shouldFail bool
 	}{
+		{actual: nil, expected: nil, shouldFail: true},
 		{actual: "", expected: 0, shouldFail: false},
 		{actual: "a", expected: 1, shouldFail: false},
 		{actual: "1", expected: 1, shouldFail: false},