(chocolatey#3242) Attempt default credentials for sources

When attempting a query to a source that requires credentials, we were always prompting for credentials. This prevents attempting the default credentials unless entering an empty password. We should attempt initially with the default credentials, and only prompt if it's a retry for credentials.
corbob · Jul 5, 2023 · fe5898b · fe5898b
1 parent d836138
commit fe5898b
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/chocolatey/infrastructure.app/nuget/ChocolateyNugetCredentialProvider.cs b/src/chocolatey/infrastructure.app/nuget/ChocolateyNugetCredentialProvider.cs
@@ -140,8 +140,16 @@ public Task<CredentialResponse> GetAsync(Uri uri, IWebProxy proxy, CredentialReq
 
             if (source == null)
             {
-                this.Log().Debug("Asking user for credentials for '{0}'".FormatWith(uri.OriginalString));
-                return Task.FromResult(new CredentialResponse(GetUserCredentials(uri, proxy, credentialType)));
+                ICredentials credential = CredentialCache.DefaultNetworkCredentials;
+
+                if (isRetry)
+                {
+                    this.Log().Debug("This is a retry attempt. Asking user for credentials for '{0}'".FormatWith(uri.OriginalString));
+                    credential = GetUserCredentials(uri, proxy, credentialType);
+
+                }
+
+                return Task.FromResult(new CredentialResponse(credential));
             }
             else
             {