Merge pull request chocolatey#2824 from AdmiringWorm/logging-tests

(chocolatey#1332) Add tests for disabling file logging of archive extractions
corbob · Sep 22, 2022 · 097b52f · 097b52f
2 parents aa184b3 + 13968e9
commit 097b52f
Show file tree

Hide file tree

Showing 5 changed files with 60 additions and 1 deletion.
diff --git a/Invoke-Tests.ps1 b/Invoke-Tests.ps1
@@ -93,7 +93,7 @@ try {
             Verbosity = 'Minimal'
         }
         Filter     = @{
-            ExcludeTag = 'Background', 'Licensed', 'CCM', 'WIP', 'NonAdmin'
+            ExcludeTag = 'Background', 'Licensed', 'CCM', 'WIP', 'NonAdmin', 'Internal'
         }
     }
 

diff --git a/tests/chocolatey-tests/choco-install.Tests.ps1 b/tests/chocolatey-tests/choco-install.Tests.ps1
@@ -1392,4 +1392,36 @@ Describe "choco install" -Tag Chocolatey, InstallCommand {
             $result2.Lines | Should -Contain "Circular dependency detected 'circulardependency2 0.0.1 => circulardependency1 0.0.1 => circulardependency2 0.0.1'."
         }
     }
+
+    Context "Installing package that extracts local zip archive while disabling logging" {
+        BeforeAll {
+            Restore-ChocolateyInstallSnapshot
+
+            $Output = Invoke-Choco install zip-log-disable-test --verbose --debug -y
+        }
+
+        It "Exits with Success (0)" {
+            $Output.ExitCode | Should -Be 0
+        }
+
+        It "Does not output extracted file path '<_>'" -ForEach @('tools\'; 'tools\chocolateybeforemodify.ps1'; 'tools\chocolateyinstall.ps1'; 'tools\chocolateyuninstall.ps1'; 'zip-log-disable-test.nuspec') {
+            $Output.String | Should -Not -Match "- $([regex]::Escape($_))"
+        }
+    }
+
+    Context "Installing package that extracts external zip archive while disabling logging" -Tag Internal {
+        BeforeAll {
+            Restore-ChocolateyInstallSnapshot
+
+            $Output = Invoke-Choco install zip-log-disable-test-external --verbose --debug -y
+        }
+
+        It "Exits with Success (0)" {
+            $Output.ExitCode | Should -Be 0
+        }
+
+        It "Does not output extracted file path '<_>'" -ForEach @('tools\'; 'tools\chocolateybeforemodify.ps1'; 'tools\chocolateyinstall.ps1'; 'tools\chocolateyuninstall.ps1'; 'zip-log-disable-test.nuspec') {
+            $Output.String | Should -Not -Match "- $([regex]::Escape($_))"
+        }
+    }
 }
diff --git a/tests/chocolatey-tests/testpackages/zip-log-disable-test/tools/chocolateyinstall.ps1 b/tests/chocolatey-tests/testpackages/zip-log-disable-test/tools/chocolateyinstall.ps1
@@ -0,0 +1,12 @@
+
+$ErrorActionPreference = 'Stop';
+$toolsDir   = "$(Split-Path -parent $MyInvocation.MyCommand.Definition)"
+
+$packageArgs = @{
+  packageName   = $env:ChocolateyPackageName
+  destination   = "$toolsDir\extraction"
+  file          = "$toolsDir\zip-log-disable-test.zip"
+  disableLogging= $true
+}
+
+Get-ChocolateyUnzip @packageArgs
diff --git a/tests/chocolatey-tests/testpackages/zip-log-disable-test/tools/zip-log-disable-test.zip b/tests/chocolatey-tests/testpackages/zip-log-disable-test/tools/zip-log-disable-test.zip
diff --git a/tests/chocolatey-tests/testpackages/zip-log-disable-test/zip-log-disable-test.nuspec b/tests/chocolatey-tests/testpackages/zip-log-disable-test/zip-log-disable-test.nuspec
@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Do not remove this test for UTF-8: if “Ω” doesn’t appear as greek uppercase omega letter enclosed in quotation marks, you should use an editor that supports UTF-8, not this one. -->
+<package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd">
+  <metadata>
+    <id>zip-log-disable-test</id>
+    <version>1.0.0</version>
+    <title>zip-log-disable-test (Install)</title>
+    <authors>__REPLACE_AUTHORS_OF_SOFTWARE_COMMA_SEPARATED__</authors>
+    <tags>zip-log-disable-test SPACE_SEPARATED</tags>
+    <description>Package used to test disabling verbose file log for zip extraction</description>
+  </metadata>
+  <files>
+    <file src="tools\**" target="tools" />
+  </files>
+</package>