-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gregg branch #6
Open
greggheller
wants to merge
37
commits into
master
Choose a base branch
from
gregg_branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gregg branch #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns, choosing appropriate images from matches in dir based on config
…from previous commit, cleaned up point copier to rely on inheritance and only act when something occured in the copied axis, changed print statements to logging.info so they can easily be hidden, add
… True doesn't carry over to the next operator
… with a right click, right click and drag is now required to clear points (instead of just right click), marker is a blue crosshairs, points can be clicked and dragged
…in redraw of points to see if it helps
…esn't require redraw, increased tolerance for clicked point and drag to delete all slightly
…nto gregg_branch
save html to SD7 for hab sessions as well
revert to save locally now that we have WSE reminding
switch to SD8
Add a clear descriptive error and a method to circumvent when one of the lims sessions has failed and so the info json doesn't have a way to get the data directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
using @Property in pointAnnotator to pull out points
used inheritance to clean up pointCopier
Added a config to help gather canidate images for registration
added functionality to choose between canidate images with click
added arrays to saved npz that are specific to the images that the points belong to, and the image pairs that a tranformation belongs to
added a function to pull appropriate points from npz for a given image to load
automatically loads points from previous sessions when possible