Updates go version and lint version in CI #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 89.28% 90.21% +0.93%
==========================================
Files 8 8
Lines 1521 1523 +2
==========================================
+ Hits 1358 1374 +16
+ Misses 142 128 -14
Partials 21 21 ☔ View full report in Codecov by Sentry. |
|
M4tteoP
commented
Jan 27, 2024
| @@ -23,7 +23,7 @@ const ( | |||
|
|
|||
| // Look forward for doubling of delimiter | |||
| // | |||
| // case 'foo''bar' -> foo''bar | |||
| // case 'foo' 'bar' -> foo' 'bar | |||
There was a problem hiding this comment.
I had to add the spaces because the linter was complaining and wanted to merge '' into ". Also my IDE was trying to do the same 🤔:
-// case 'foo''bar' -> foo''bar
+// case 'foo”bar' -> foo”bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.