Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: rename methods for a better description of what they do. #518

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

jcchavezs
Copy link
Member

While these are breaking changes, I think the naming describes better what they do.

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Make sure that you've checked the boxes below before you submit PR:

Thanks for your contribution ❤️

@jcchavezs jcchavezs marked this pull request as ready for review November 28, 2022 23:18
@jcchavezs jcchavezs requested a review from a team as a code owner November 28, 2022 23:18
// criteria to be processed, response headers must be set before this.
// The content-type response header must be in the SecResponseBodyMimeType
// This is used by webservers to choose whether to stream response buffers
// directly to the client or write them to Coraza's buffer.
IsProcessableResponseBody() bool
IsResponseBodyProcessable() bool
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns with IsResponseBodyAccessible

@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 82 Code Smells

0.0% 0.0% Coverage
0.1% 0.1% Duplication

Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jptosso jptosso merged commit 63a49c8 into v3/dev Nov 29, 2022
@jptosso jptosso deleted the rename_methods branch November 29, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants