Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize body buffering. #505

Merged
merged 4 commits into from
Nov 18, 2022
Merged

feat: optimize body buffering. #505

merged 4 commits into from
Nov 18, 2022

Conversation

jcchavezs
Copy link
Member

This PR attemps to prove the usefulnes of #499 by refactoring the logic and avoiding buffering request/response body when no need.

Ping @M4tteoP @anuraaga @jptosso

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Make sure that you've checked the boxes below before you submit PR:

Thanks for your contribution ❤️

@jcchavezs jcchavezs requested a review from a team as a code owner November 14, 2022 20:49
@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 82 Code Smells

0.0% 0.0% Coverage
0.1% 0.1% Duplication

@jcchavezs
Copy link
Member Author

SonarCloud is complaining about lack of coverage in files I did not touch, also I am including tests in this PR
image
Can we merge it as it is?

@jcchavezs jcchavezs merged commit 128e9a3 into v3/dev Nov 18, 2022
@jcchavezs jcchavezs deleted the optimize_body_buffering branch November 18, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants