Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mage commands in CI instead of pre-commit #355

Merged
merged 5 commits into from
Oct 3, 2022

Conversation

anuraaga
Copy link
Contributor

Also

  • Removes tinygo.yml from v2 since there aren't any tinygo tests
  • Updates action versions
  • Removes lfs and fetch-depth from checkout since they don't seem to be used
  • Adds cache for Go to speed up compilation of commands

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Note: that go.mod and go.sum can only be modified for tested dependency updates or justified new features.

Make sure that you've checked the boxes below before you submit PR:

Thanks for your PR ❤️

@@ -11,11 +11,10 @@ linters:
- govet
- ineffassign
- staticcheck
- structcheck
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not supported on Go 1.18+

Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcchavezs jcchavezs merged commit ed44740 into corazawaf:v2/master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants