Use io.Discard instead of /dev/null for discarding output #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
commented
Aug 23, 2022
jptosso
reviewed
Aug 23, 2022
loggers/serial_writer.go
Outdated
| } else { | ||
| file = io.Discard | ||
| // Nothing to close so just set a no-op | ||
| sl.file = io.NopCloser(&bytes.Buffer{}) |
There was a problem hiding this comment.
We still don't have a mechanism to close WAF instances. It should handle closing log writters and audit writters.
There was a problem hiding this comment.
Just to confirm this is something to fix in another PR? Here we're just keeping the existing code working, i.e., to support the Close method on line 58
jcchavezs
reviewed
Aug 23, 2022
jcchavezs
reviewed
Aug 23, 2022
jcchavezs
reviewed
Aug 25, 2022
jcchavezs
reviewed
Aug 25, 2022
jcchavezs
reviewed
Aug 25, 2022
|
Hi all, this has been open for a while can it be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing to
/dev/nullis still a system call which adds quite a bit of overhead even though we don't want to actually do anything.io.Discarddrops within Go code itself for much better efficiency, and a step towards Windows compatibility.Note: that go.mod and go.sum can only be modified for tested dependency updates or justified new features.
Make sure that you've checked the boxes below before you submit PR:
Thanks for your PR ❤️