-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #193 #199
Fix for issue #193 #199
Conversation
@jptosso Please review this |
Thank you for your contribution. Could you please fix the code to pass the github action? |
@Bxlxx Why we got this for compatibility/test?
|
I'm trying to fix the problem. Please wait a moment. |
Not sure if it's due to this file, https://github.com/jptosso/coraza-pcre/blob/master/go.mod
|
It seems you are right, that's because I have created a tag for the renamed project. I will fix it |
What needs to be done here? Do we need to rebase also, right? |
It is a valid solution and it's passing tests but I think we should discuss this one. Maybe adding the parent ID as a parameter is too much and we could add the parent rule id to MatchedData |
Sounds good, let me check the code again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now.
It seems it's not enough to fix the issue: #193 (comment) We will do some additional research on this one. |
What is needed here now? Can we document what's the actual state? |
So the issue reporter said it's wrong but we haven't received the detailed feedback. I will try to get it today. |
Please review #216 |
Closed in favor of #220 Thank you Shiming, your PR was technically right but exporting new fields is a sensitive topic and we should avoid it if possible. Also tests were required. |
Note: that go.mod and go.sum can only be modified for tested dependency updates or justified new features.
Make sure that you've checked the boxes below before you submit PR:
Thanks for your PR ❤️