Fix for issue #193

[ShiMing-Q]

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Note: that go.mod and go.sum can only be modified for tested dependency updates or justified new features.

Make sure that you've checked the boxes below before you submit PR:

• My code includes positive and negative tests.
• I have an appropriate description with correct grammar.
• I have read Contribution guidelines, maintainers note and Quality standard.

Thanks for your PR ❤️

[ShiMing-Q]

@jptosso Please review this

[syinwu]

@jptosso Please review this

Thank you for your contribution. Could you please fix the code to pass the github action?

[ShiMing-Q]

@Bxlxx Why we got this for compatibility/test?

go: downloading go.uber.org/multierr v1.8.0
go get: github.com/jptosso/coraza-waf/[email protected]: parsing go.mod:
	module declares its path as: github.com/corazawaf/coraza/v2
	        but was required as: github.com/jptosso/coraza-waf/v2
Error: Process completed with exit code 1.

[syinwu]

@Bxlxx Why we got this for compatibility/test?

go: downloading go.uber.org/multierr v1.8.0
go get: github.com/jptosso/coraza-waf/[email protected]: parsing go.mod:
	module declares its path as: github.com/corazawaf/coraza/v2
	        but was required as: github.com/jptosso/coraza-waf/v2
Error: Process completed with exit code 1.

I'm trying to fix the problem. Please wait a moment.

[ShiMing-Q]

Not sure if it's due to this file, https://github.com/jptosso/coraza-pcre/blob/master/go.mod

# go get -u github.com/jptosso/coraza-pcre@1bea0f0
go: downloading github.com/jptosso/coraza-waf/v2 v2.0.0-rc.3
go: downloading go.uber.org/multierr v1.8.0
go get: github.com/jptosso/coraza-waf/[email protected]: parsing go.mod:
	module declares its path as: github.com/corazawaf/coraza/v2
	        but was required as: github.com/jptosso/coraza-waf/v2

[jptosso]

Not sure if it's due to this file, https://github.com/jptosso/coraza-pcre/blob/master/go.mod

# go get -u github.com/jptosso/coraza-pcre@1bea0f0
go: downloading github.com/jptosso/coraza-waf/v2 v2.0.0-rc.3
go: downloading go.uber.org/multierr v1.8.0
go get: github.com/jptosso/coraza-waf/[email protected]: parsing go.mod:
	module declares its path as: github.com/corazawaf/coraza/v2
	        but was required as: github.com/jptosso/coraza-waf/v2

It seems you are right, that's because I have created a tag for the renamed project. I will fix it

[fzipi]

What needs to be done here? Do we need to rebase also, right?

[jptosso]

It is a valid solution and it's passing tests but I think we should discuss this one.

Maybe adding the parent ID as a parameter is too much and we could add the parent rule id to MatchedData

[ShiMing-Q]

It is a valid solution and it's passing tests but I think we should discuss this one.

Maybe adding the parent ID as a parameter is too much and we could add the parent rule id to MatchedData

Sounds good, let me check the code again.

[fzipi]

Looking good now.

[jptosso]

It seems it's not enough to fix the issue: #193 (comment) We will do some additional research on this one.

[fzipi]

What is needed here now? Can we document what's the actual state?

[jptosso]

So the issue reporter said it's wrong but we haven't received the detailed feedback. I will try to get it today.

[jptosso]

Please review #216

[jptosso]

Closed in favor of #220

Thank you Shiming, your PR was technically right but exporting new fields is a sensitive topic and we should avoid it if possible. Also tests were required.