feat: registers RegisterFormatters for tinygo
#1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
reviewed
Mar 26, 2024
jcchavezs
reviewed
Mar 28, 2024
| } | ||
|
|
||
| // wasmSerial emulates a custom audit log writer that writes to the log in wasm | ||
| type wasmSerial struct { |
There was a problem hiding this comment.
I would not call it wasmSerial but redeclare serial here for tinygo only
M4tteoP
commented
Mar 28, 2024
| @@ -13,7 +13,7 @@ func init() { | |||
| return noopWriter{} | |||
| }) | |||
| RegisterWriter("serial", func() plugintypes.AuditLogWriter { | |||
| return noopWriter{} | |||
| return &serialWriter{} | |||
There was a problem hiding this comment.
jcchavezs
approved these changes
Mar 28, 2024
|
shall we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address
coraza/internal/auditlog/init_tinygo.go
Line 22 in 0af085c
JSON audit logs should be now supported by tiny go, therefore the PR proposes to build the audit log formatters also for it. See corazawaf/coraza-proxy-wasm#263