feat(systemd): systemd improvements #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set notify-reload type and use the sd_notify to signal the daemon the readiness of the application
fionera
requested changes
Nov 15, 2024
DavidProdinger
pushed a commit
to DavidProdinger/coraza-spoa
that referenced
this pull request
Nov 18, 2024
This will be handled in corazawaf#133
added 2 commits
November 18, 2024 17:32
Debian 12 doesn't support the new notify-reload type, therefore selecting the notify type
fionera
requested changes
Nov 20, 2024
do not use the extra functions for the SdNotify Allow multiple parameters, which are joined into separate lines Add logging hook on fatal level to send message as STOPPING=1\nSTATUS=[msg] to the service manager
|
Can you add tests? |
DavidProdinger
changed the title
|
Maybe we could add tests here for the deb installing and running/reloading/stopping, as mentioned in #143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the systemd file to work better with the
SIGHUPUNIX process signalTechnical
Setting the systemd
Typetonotify-reload(see docs)This kind of unit file expects the application to notify the daemon via sd_notify with the following signals:
READY=1RELOADING=1MONOTONIC_USEC=...(not added yet)Other fixes
I fixed the systemd unit file with the wrong syntax
InaccessiblePaths=-/bin/findFixes #102