chore: adds dashboard. #222
Conversation
example/grafana/dashboard.json
Outdated
| @@ -0,0 +1,234 @@ | |||
| { | |||
There was a problem hiding this comment.
If this or other files are copied from somewhere it would be good to have a link somewhere.
There was a problem hiding this comment.
Actually this was done myself from try/fail. Couldn't find a decent dashboard to work for me (there are many and also an official but I couldn't make them work)
M4tteoP
force-pushed
the
adds_dashboard
branch
from
a585957 to
0eb0c07
Compare
|
I rebased the PR, addressed some reviews and extended the dashboard. Now it looks like: |
|
Shall we borrow some metrics from https://grafana.com/grafana/dashboards/13277-istio-wasm-extension-dashboard/ ? cc @zirain |
absolutely, you should. |
why not use MiB? |
example/grafana/grafana.ini
Outdated
| instance_name = "grafana" | ||
|
|
||
| [security] | ||
| admin_user = admin |
There was a problem hiding this comment.
I think it's better to set these as environment variables in the docker-compose rather than a file to avoid making an example of insecure values
https://grafana.com/docs/grafana/latest/setup-grafana/configure-grafana/#override-configuration-with-environment-variables
GC_SECURITY_ADMIN_USER / _PASSWORD
There was a problem hiding this comment.
I would not overcomplicate it as this is just for example purposes and inside the scope of docker compose.
There was a problem hiding this comment.
Especially if moving the files it's probably ok - though I don't know if it's particularly complicated using variables either :P
M4tteoP
force-pushed
the
adds_dashboard
branch
from
d8419f5 to
021e3a3
Compare
|
Reviews should be addressed, PTAL. I would love to merge an initial memory dashboard also for doing some comparisons about #252. |
Often people talks about memory consumption by coraza-proxy-wasm, however it would be easier to understand what is going on with the config applied plus a dashboard screenshot, hence this PR.
Related to #191 #219
Closes #221