-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORL-1412] Integrate giphy web SDK #3255
Conversation
package.json
Outdated
@@ -136,11 +138,13 @@ | |||
"prom-client": "^12.0.0", | |||
"proxy-agent": "^3.1.1", | |||
"querystringify": "^2.1.1", | |||
"react-use": "^15.3.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this library is just being used for a nice useDebounce
(imported independently) but if we don't want to add this dep i'm happy to write my own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dependencies are great, but can we move them to devDependencies
? They aren't used by the server so we don't need to include it in dependencies
.
package.json
Outdated
@@ -136,11 +138,13 @@ | |||
"prom-client": "^12.0.0", | |||
"proxy-agent": "^3.1.1", | |||
"querystringify": "^2.1.1", | |||
"react-use": "^15.3.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dependencies are great, but can we move them to devDependencies
? They aren't used by the server so we don't need to include it in dependencies
.
package.json
Outdated
"source-map-support": "^0.5.16", | ||
"stack-utils": "^2.0.1", | ||
"striptags": "^3.1.1", | ||
"tsscmp": "^1.0.6", | ||
"url-regex": "^5.0.0", | ||
"use-resize-observer": "^6.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually already have our own resize observer provided by:
import { useResizeObserver } from "coral-framework/hooks";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this provides a better API though, I'd replace our implementation with the package one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does provide a better API in my opinion, I've replaced our implementation in the one place it was used.
6129528
to
756d134
Compare
What does this PR do?
Turns out giphy released a web sdk complete with react components shortly after we built our own custom UI. Theirs is better, but there's a couple tradeoffs.
Pros:
Cons:
What changes to the GraphQL/Database Schema does this PR introduce?
giphy rating and api key are now public
How do I test this PR?
search and select gifs on desktop and mobile