Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default span metrics in ebpf agent deployment #491

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

default span metrics in ebpf agent deployment #491

wants to merge 3 commits into from

Conversation

NimrodAvni78
Copy link
Contributor

Description

for default deployment of ebpf agent, we want customers to prefer to use span metrics preset as default

#AN-121

How Has This Been Tested?

Checklist:

  • [*] I have updated the relevant Helm chart(s) version(s)
  • [*] I have updated the relevant component changelog(s)
  • [*] This change does not affect any particular component (e.g. it's CI or docs change)

@NimrodAvni78 NimrodAvni78 force-pushed the feature/ebpf-span-metrics-preset branch from 2ae0e2e to 1b6b02b Compare December 23, 2024 09:27
povilasv
povilasv reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@povilasv povilasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also CI is failing on docs

@NimrodAvni78 NimrodAvni78 force-pushed the feature/ebpf-span-metrics-preset branch from bbbf537 to e1ab111 Compare December 25, 2024 18:05
@NimrodAvni78 NimrodAvni78 force-pushed the feature/ebpf-span-metrics-preset branch from e1ab111 to 63fc16f Compare December 25, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@povilasv povilasv povilasv left review comments

@amir-golani amir-golani Awaiting requested review from amir-golani

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NimrodAvni78 @povilasv