Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES-364] e2e add telemetrygen for traces #466

Merged
merged 136 commits into from
Dec 6, 2024
Merged

[ES-364] e2e add telemetrygen for traces #466

merged 136 commits into from
Dec 6, 2024

Conversation

ryantanjunming
Copy link
Contributor

@ryantanjunming ryantanjunming commented Oct 25, 2024 •
edited
Loading

Description

Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@ryantanjunming
telemetrygen add deployment
0213589
@ryantanjunming
deployment error fix, output
7652573
@ryantanjunming
label mistake
7a3be8a
@ryantanjunming
run in one block, wait for both
0963c5e
@ryantanjunming
wrong location
798c3ae
@ryantanjunming
typo
7e80f68
@ryantanjunming
spans add
6c54a4a
@ryantanjunming
rejected spans metric
b1981dd
@ryantanjunming
another metric detected
6116cad
@ryantanjunming
another
44313f5
@ryantanjunming
get current full list
e67497a
@ryantanjunming
add all metrics detected and sort
ddb0f0e
@ryantanjunming
add missing metrics
d03fa04
@ryantanjunming
traces sink creation
e0ae4e6
@ryantanjunming
check spans schemaUrl
94c770c
@ryantanjunming
Merge branch 'master' into feature/e2e-telemetrygen
2ac166f
@ryantanjunming
raise time to get more traces
b297263
@ryantanjunming
longer duration
9a1b574
@ryantanjunming
refactoring, need to add telemetrygen to k8s via code
8e2640f
@ryantanjunming
typo
cfaa938
@ryantanjunming
testing
73b46b6
@ryantanjunming
update go packages
60de516
@ryantanjunming
try not waiting for pods
b3afcb9
@ryantanjunming
import otel contrib k8stest library
ee5e06e
@ryantanjunming
try removing telemetrygen
45c84a9
@ryantanjunming
import otel test code
0ff26a6
@ryantanjunming
kubeconfig passing
60aa7a5
@ryantanjunming
print kubeconfig
a43af8e
@ryantanjunming
display step
c331f80
@ryantanjunming
kubeconfig path
c348e2c
douglascamata
douglascamata previously requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good!

I have a few new comments and some old ones that are still not resolved.

otel-integration/k8s-helm/e2e-test/main_test.go Outdated Show resolved Hide resolved
otel-integration/k8s-helm/e2e-test/main_test.go Outdated Show resolved Hide resolved
otel-integration/k8s-helm/e2e-test/main_test.go Outdated Show resolved Hide resolved
otel-integration/k8s-helm/e2e-test/sinks.go Show resolved Hide resolved
otel-integration/k8s-helm/e2e-test/sinks.go Outdated Show resolved Hide resolved
otel-integration/k8s-helm/e2e-test/testdata/values-e2e-test.yaml Outdated Show resolved Hide resolved
ryantanjunming and others added 14 commits November 30, 2024 07:38
@povilasv
Copy link
Contributor

povilasv commented Dec 4, 2024

@ryantanjunming I think a bunch of the common files are copied from otel collector? Could we maybe import them via packages or it's not possible?

@ryantanjunming
Copy link
Contributor Author

Will reference the oteltest as a package in the next e2e ticket, thanks

@ryantanjunming
changelog
3a62912
@ryantanjunming
Merge branch 'master' into feature/e2e-telemetrygen
808eaec 
# Conflicts:
#	otel-integration/CHANGELOG.md
#	otel-integration/k8s-helm/Chart.yaml
#	otel-integration/k8s-helm/values.yaml
@ryantanjunming
e2e changelog again
09c18c3
@ryantanjunming ryantanjunming merged commit 0607b35 into master Dec 6, 2024
7 checks passed
@ryantanjunming ryantanjunming deleted the feature/e2e-telemetrygen branch December 6, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royfur royfur royfur left review comments

@povilasv povilasv povilasv approved these changes

@douglascamata douglascamata douglascamata left review comments

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryantanjunming @povilasv @douglascamata @royfur