[otel-integration] fix support for openshift #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
requested review from
avivgold098,
ShauliSolomovich,
oded-dd,
matej-g and
nicolastakashi
as code owners
povilasv
force-pushed
the
openshift-integration
branch
from
72eb271 to
dbe09f9
Compare
povilasv
commented
Oct 31, 2023
matej-g
approved these changes
Oct 31, 2023
nicolastakashi
pushed a commit
that referenced
this pull request
Oct 31, 2023
nicolastakashi
pushed a commit
that referenced
this pull request
Oct 31, 2023
nicolastakashi
pushed a commit
that referenced
this pull request
Oct 31, 2023
nicolastakashi
added a commit
that referenced
this pull request
Oct 31, 2023
Co-authored-by: Povilas Versockas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes ES-136
Running otel-integration resulted in a bunch of templating errors, agent / ksm didn't spin up.
This fixes that.
KSM will use non-rootv2 default SCC (Ref: https://docs.openshift.com/container-platform/4.11/authentication/managing-security-context-constraints.html)
How Has This Been Tested?
Manually tested using https://crc.dev/crc/getting_started/getting_started/introducing/
Checklist: