Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Trace links in SQS #3

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

povilasv
Copy link

@povilasv povilasv changed the title add trace id to sqs SendMessage message attributes add support for Trace links in SQS Sep 18, 2023
@povilasv povilasv marked this pull request as ready for review September 20, 2023 08:14
Copy link

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can follow the code, the test failures seem related though.

Copy link

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending fix for the failing CI

@povilasv
Copy link
Author

Made a ticket for CI https://coralogix.atlassian.net/browse/ES-98, thanks for reviews

@povilasv povilasv merged commit 6888864 into coralogix-python-dev Sep 20, 2023
53 of 71 checks passed
@povilasv povilasv deleted the dev-python-fixes branch September 20, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants