Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] adding target allocator configs #123

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Conversation

nicolastakashi
Copy link
Collaborator

@nicolastakashi nicolastakashi commented Nov 28, 2024

This pull request includes several updates to the OpenTelemetry Collector Helm chart, primarily adding new configurations for the Target Allocator and improving the deployment configurations.

Key changes include:

New Configurations for Target Allocator:

  • Added new configurations for serviceMonitorNamespaceSelector, podMonitorNamespaceSelector, scrapeconfigs, and probes in the clusterrole-targetallocator.yaml file. [1] [2]
  • Introduced new definitions for serviceMonitorNamespaceSelector and podMonitorNamespaceSelector in the _helpers.tpl file.
  • Updated the configmap-targetallocator.yaml to include new configurations for serviceMonitorNamespaceSelector and podMonitorNamespaceSelector.

Deployment Enhancements:

  • Added support for affinity, tolerations, volumeMounts, livenessProbe, readinessProbe, and minReadySeconds in the deployment-targetallocator.yaml file. [1] [2]
  • Introduced a new PodDisruptionBudget configuration in the pdb-targetallocator.yaml file.

Service and Monitoring Updates:

  • Added appProtocol: http to the service-targetallocator.yaml file.
  • Introduced a new ServiceMonitor configuration in the servicemonitor-targetallocator.yaml file.

Version and Metadata Updates:

  • Updated the chart version to 0.98.5 in the Chart.yaml file.
  • Added a new changelog entry for version 0.98.5 in the CHANGELOG.md file.

Schema and Values Updates:

  • Updated the values.schema.json to include new properties for tolerations, affinity, volumeMounts, volumes, serviceMonitor, pdb, livenessProbe, readinessProbe, and minReadySeconds.
  • Updated the values.yaml file to include default values for the new configurations. [1] [2] [3]

@nicolastakashi nicolastakashi force-pushed the feat/adding-configs-ta branch 4 times, most recently from ac3c4dd to d3b5f4f Compare November 28, 2024 21:59
Copy link
Collaborator

@daidokoro daidokoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@nicolastakashi nicolastakashi merged commit c13ffa8 into main Nov 30, 2024
3 checks passed
@nicolastakashi nicolastakashi deleted the feat/adding-configs-ta branch November 30, 2024 09:22
douglascamata added a commit to coralogix/telemetry-shippers that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants