-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 100% cpu #13
fix 100% cpu #13
Conversation
@DimaGolomozy, it appears your commits are unsigned, this is a merge requirement on this repo. You should be able to retroactively sign these commits then we'll re-approve and get this change merged. |
ed4da4e
to
6ac17bd
Compare
both commits are signed now |
it looks like I'm having problems with signing.. |
@daidokoro are you guys going to merge this? |
6ac17bd
to
7dfac53
Compare
@daidokoro also here.. commits are signed and verified |
Excellent @DimaGolomozy , the verification works, but there are some conflicts for this one. Can you please resolve? Thanks in advance. |
Signed-off-by: dimagolomozy <[email protected]>
Signed-off-by: dimagolomozy <[email protected]>
7dfac53
to
c35e318
Compare
@daidokoro done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks. |
@DimaGolomozy, done |
well, this is quite funny... in
go
this made
time.Sleep(time.Duration(NextSendInterval) * time.Second)
to be the same astime.Sleep(0 * time.Second)
that made the 100% CPU (as described here: #6) because the for loop never sleep
better to use an explicit
time.Duration
type. plus i added an option to override this property when creating the loggeri belive this fixes issues:
#11
#6