[refactor] alert reconciler #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Takashi <[email protected]>
ArthurSens
reviewed
Apr 22, 2024
nicolastakashi
force-pushed
the
chore/refactoring-alertreconciler
branch
6 times, most recently
from
633b664 to
e0dd1eb
Compare
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
Signed-off-by: Nicolas Takashi <[email protected]>
nicolastakashi
force-pushed
the
chore/refactoring-alertreconciler
branch
from
e0dd1eb to
e518933
Compare
povilasv
approved these changes
Apr 30, 2024
OrNovo
previously approved these changes
May 5, 2024
Co-authored-by: Povilas Versockas <[email protected]>
nicolastakashi
force-pushed
the
chore/refactoring-alertreconciler
branch
from
9a15a93 to
8edd393
Compare
matej-g
previously approved these changes
May 6, 2024
Co-authored-by: Matej Gera <[email protected]>
nicolastakashi
force-pushed
the
chore/refactoring-alertreconciler
branch
from
3f16272 to
89f207f
Compare
matej-g
approved these changes
May 6, 2024
|
🎉 This PR is included in version 0.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates the Go version from 1.20 to 1.22 and makes several changes to the codebase to improve its efficiency and readability. The major changes include updating the Go version in multiple GitHub workflow files and the Dockerfile, updating the Controller Tools version in the Makefile, refactoring the
AlertSpecandAlertstructs inalert_types.go, and making changes to theAlertReconcilerstruct inalert_controller.go.Updates to Go version:
.github/workflows/build.yml: Updated Go version from 1.20.x to 1.22.x in the GitHub workflow..github/workflows/docs.yml: Updated Go version from 1.20.x to 1.22.x in the GitHub workflow..github/workflows/e2e-tests.yaml: Updated Go version from 1.20.x to 1.22.x in the GitHub workflow.Dockerfile: Updated Go version from 1.20 to 1.22 in the Dockerfile.go.mod: Updated Go version from 1.20 to 1.22.Updates to Makefile:
Makefile: Updated the Controller Tools version from v0.9.2 to v0.15.0.Refactoring of
AlertSpecandAlertstructs:apis/coralogix/v1alpha1/alert_types.go: Refactored theAlertSpecstruct to simplify theExtractCreateAlertRequestmethod and changed the receiver fromin *AlertSpectoa *Alert. Added aNewAlertmethod to theAlertstruct. [1] [2]Changes to
AlertReconcilerstruct:controllers/alphacontrollers/alert_controller.go: Made several changes to theAlertReconcilerstruct, including replacing thejsonpb.Marshalerwithlogr.Logger, refactoring theReconcilemethod, and updating theflattenAlertfunction to return a non-pointerAlertStatus. [1] [2] [3]Updates to dependencies:
go.mod: Updated thek8s.io/utilsdependency version.