[FIX] error checking causing panic (#103)

Signed-off-by: Nicolas Takashi <[email protected]>
coralogix · May 6, 2024 · 4b62434 · 4b62434
1 parent 631c4a4
commit 4b62434
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/controllers/alphacontrollers/alert_controller.go b/controllers/alphacontrollers/alert_controller.go
@@ -988,7 +988,7 @@ func flattenNotificationGroups(ctx context.Context, notificationGroups []*alerts
 	var err error
 	for _, ng := range notificationGroups {
 		notificationGroup, flattenErr := flattenNotificationGroup(ctx, ng)
-		if err != nil {
+		if flattenErr != nil {
 			err = stdErr.Join(err, fmt.Errorf("error on flatten notification-groups - %w", flattenErr))
 			continue
 		}
@@ -1018,6 +1018,7 @@ func flattenNotifications(ctx context.Context, notifications []*alerts.AlertNoti
 		flattenedNotification, flattenErr := flattenNotification(ctx, notification)
 		if flattenErr != nil {
 			err = stdErr.Join(err, fmt.Errorf("error on flatten notifications - %w", flattenErr))
+			continue
 		}
 		result = append(result, flattenedNotification)
 	}