-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small improvements to object store #52
base: object-store-0.10.2
Are you sure you want to change the base?
Conversation
@@ -319,7 +320,7 @@ impl ObjectStore for AmazonS3 { | |||
|
|||
#[derive(Debug)] | |||
struct S3MultiPartUpload { | |||
part_idx: usize, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand this change. Using an atomic here would be irrelevant as in both put_part
and complete
we have a mutable reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, you're right 🤦
Fixing some issues related to the object store