Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename metadata interface ix fields from token_program_id to program_id #3076

Conversation

jacksondoherty
Copy link
Contributor

@jacksondoherty jacksondoherty commented Jul 8, 2024

See #3073.

Rename fields to better reflect interface structure and match spl_token_metadata_interface and spl_token_group_interface instructions.

Copy link

vercel bot commented Jul 8, 2024

@jacksondoherty is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@jacksondoherty jacksondoherty marked this pull request as ready for review July 8, 2024 19:20
@acheroncrypto acheroncrypto added spl breaking next Required for the next release labels Jul 10, 2024
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We can get this in before the next breaking release. Holding off for now to give us the option of a patch release in-between.

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need a patch release since the upstream SPL issue regarding Solana v2 (#3044) has been fixed with the new release of SPL crates.

Before we merge, could you note this breaking change in the CHANGELOG?

@jacksondoherty jacksondoherty force-pushed the rename-metadata-interface-ix-fields branch from afa8af2 to c54bf82 Compare August 5, 2024 15:04
@jacksondoherty
Copy link
Contributor Author

Sorry, lost track of this – breaking note added to CHANGELOG + rebased with latest changes from master 👍

@@ -57,6 +57,7 @@ The minor version will be incremented upon a breaking change and the patch versi
- lang: Require `Discriminator` trait impl when using the `zero` constraint ([#3118](https://github.com/coral-xyz/anchor/pull/3118)).
- ts: Remove `DISCRIMINATOR_SIZE` constant ([#3120](https://github.com/coral-xyz/anchor/pull/3120)).
- lang: `#[account]` attribute arguments no longer parses identifiers as namespaces ([#3140](https://github.com/coral-xyz/anchor/pull/3140)).
- spl: Rename metadata interface instruction fields from `token_program_id` to `program_id` ([3076](https://github.com/coral-xyz/anchor/pull/3076)).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "#":

Suggested change
- spl: Rename metadata interface instruction fields from `token_program_id` to `program_id` ([3076](https://github.com/coral-xyz/anchor/pull/3076)).
- spl: Rename metadata interface instruction fields from `token_program_id` to `program_id` ([#3076](https://github.com/coral-xyz/anchor/pull/3076)).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind — I was going to commit this before merging, but couldn't due to this branch belonging to an organization's fork

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@acheroncrypto acheroncrypto merged commit 442541e into coral-xyz:master Aug 6, 2024
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking next Required for the next release spl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants